fix: correct dmaker-p5 fan speed range in spec_modify#1714
Open
JiasenL wants to merge 1 commit into
Open
Conversation
prop.2.6 (piid=6) on the dmaker-p5 is a 0-100 speed percentage but the MIoT cloud spec describes it as a 4-item value-list. This causes the fan to run at 4% when set to 100% (the value-list index 4 is sent as the speed value directly). Override with value-range [0, 100, 1] so the integration sends the correct percentage value to the device. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prop.2.6(piid=6) on the dmaker-p5 fan is used by the device firmware as a 0–100 speed percentage, but the MIoT cloud spec describes it with a 4-itemvalue-list(values 1–4)4to the device — which the device interprets as 4% speedKeyErrorcrashes in_speed_name_mapprop.2.6withvalue-range: [0, 100, 1]so the integration sends the correct percentage and reads feedback correctlyTest plan
on prop msg error/KeyErrorin HA logs fordid: 241255235, siid: 2, piid: 6🤖 Generated with Claude Code